Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0-fr1] Prevent NM from automatic (DHCP) configuration on ethernet devices #859

Open
wants to merge 1 commit into
base: 18.0-fr1
Choose a base branch
from
Open

[18.0-fr1] Prevent NM from automatic (DHCP) configuration on ethernet devices #859

wants to merge 1 commit into from
+25 −5

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #840

/assign vcandapp

@vcandapp
Prevent NM from automatic (DHCP/SLAAC) configuration on ethernet devices
7c11e89 
When edpm_network_config role uses os-net-config to perform
host network configuration, duplicate DHCP requests from NM are causing
issue. Eg.
https://issues.redhat.com/browse/OSPRH-9142

This fix prevents NM to configure DHCP by default

Signed-off-by: vcandapp <[email protected]>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 22, 2025
Merged
@openshift-ci openshift-ci bot requested review from dprince and rebtoor January 22, 2025 10:42
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign viroel for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vcandapp vcandapp requested a review from rabi January 22, 2025 10:42
slagle
slagle reviewed Jan 22, 2025
View reviewed changes
Copy link
Contributor

@slagle slagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The jira has a Fix Version of FR2. Unless that's incorrect, this doesn't need to be backported.

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2b6013fb4fd6473da6e339b4ece4e033

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 14m 54s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 18m 17s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 30m 36s
❌ edpm-ansible-tempest-multinode FAILURE in 2h 20m 33s
✔️ edpm-ansible-molecule-edpm_bootstrap SUCCESS in 7m 13s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 5m 47s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 4m 51s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 10m 08s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 9m 55s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 10m 33s
✔️ edpm-ansible-molecule-edpm_frr SUCCESS in 7m 33s
✔️ edpm-ansible-molecule-edpm_iscsid SUCCESS in 4m 48s
✔️ edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 8m 26s
✔️ edpm-ansible-molecule-edpm_ovs SUCCESS in 12m 49s
✔️ edpm-ansible-molecule-edpm_tripleo_cleanup SUCCESS in 4m 14s
✔️ edpm-ansible-molecule-edpm_tuned SUCCESS in 6m 15s
✔️ edpm-ansible-molecule-edpm_telemetry_power_monitoring SUCCESS in 8m 12s
✔️ adoption-standalone-to-crc-ceph-provider SUCCESS in 2h 59m 13s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slagle slagle slagle left review comments

@dprince dprince Awaiting requested review from dprince

@rebtoor rebtoor Awaiting requested review from rebtoor

@rabi rabi Awaiting requested review from rabi

Assignees

@vcandapp vcandapp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@openshift-cherrypick-robot @slagle @vcandapp